Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [UI] clickhouse queries in alert builder #1706

Merged
merged 19 commits into from Nov 24, 2022
Merged

feat: [UI] clickhouse queries in alert builder #1706

merged 19 commits into from Nov 24, 2022

Conversation

mindhash
Copy link
Contributor

@mindhash mindhash commented Nov 10, 2022 •
edited

This PR introduces following features:

  • Clickhouse tab in alert builder to support native ch queries
  • Alert type selection to identify source data for alerts - could be metrics, logs or traces
  • minor changes in new widget metric builder (ch query section) to support alphabet keys.

References:
Issue# 1699
PRD

@request-info
Copy link

request-info bot commented Nov 10, 2022

We would appreciate it if you could provide us with more info about this issue/pr!

@mindhash mindhash marked this pull request as ready for review November 21, 2022 05:18
palashgdev
palashgdev suggested changes Nov 21, 2022
View reviewed changes
frontend/src/container/CreateAlertRule/SelectAlertType/index.tsx Outdated Show resolved Hide resolved
frontend/src/container/CreateAlertRule/SelectAlertType/styles.ts Outdated Show resolved Hide resolved
frontend/src/container/CreateAlertRule/styles.ts Outdated Show resolved Hide resolved
frontend/src/container/FormAlertRules/ChQuerySection.tsx Show resolved Hide resolved
frontend/src/container/FormAlertRules/ChartPreview/index.tsx Outdated Show resolved Hide resolved
frontend/src/container/FormAlertRules/index.tsx Outdated Show resolved Hide resolved
frontend/src/container/FormAlertRules/index.tsx Show resolved Hide resolved
frontend/src/container/NewWidget/LeftContainer/QuerySection/QueryBuilder/clickHouse/index.tsx Outdated Show resolved Hide resolved
frontend/src/types/api/alerts/create.ts Outdated Show resolved Hide resolved
frontend/src/types/api/alerts/create.ts Outdated Show resolved Hide resolved
@pranay01 pranay01 mentioned this pull request Nov 22, 2022
Closed
@mindhash mindhash changed the title feat: added ui changes to support clickhouse queries in alert builder feat: [UI] clickhouse queries in alert builder Nov 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.6% 3.6% Duplication

palashgdev
palashgdev approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now will take suggestions in future

@palashgdev palashgdev merged commit 220f848 into SigNoz:develop Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

Assignees
No one assigned
Labels
request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mindhash @palashgdev @pranay01