fix(query_range): invalid memory address or nil pointer dereference #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
codeball:needs-careful-review
github-actions
bot
dismissed
their stale review
confidence: 0.21 | [dashboard]
ankitnayan
approved these changes
Dec 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1685
There are two helpful pointers from the query service log shared by the issue author.
This arises from the Prometheus library, relevant issue here prometheus/prometheus#6139
This usually happens when the context is cancelled. It's not clear why it's cancelled in the linked issue context.
Either way, we don't want to let the code run beyond this error point and throw a nil pointer exception. I will leave that issue open until we get to the bottom of the issue if we can find a way to reproduce it.