Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing github workflow push pipeline #190

Merged
merged 2 commits into from Jun 26, 2021
Merged

Fixing github workflow push pipeline #190

merged 2 commits into from Jun 26, 2021

Conversation

imrajdas
Copy link
Contributor

Issues

  • artifact env didn't set properly
  • docker tag flag was missing in the docker build command

Screenshot 2021-06-26 at 1 23 59 AM

@imrajdas
adding download env step in github workflow
6077e9b 
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
@imrajdas
adding download env step in github workflow
2a13d14 
Signed-off-by: rajdas98 <mail.rajdas@gmail.com>
@imrajdas
Copy link
Contributor Author

Tested here- https://github.com/rajdas98/signoz/actions/runs/972529275

@imrajdas
Copy link
Contributor Author

cc: @ankitnayan

@ankitnayan ankitnayan merged commit 1d5ce42 into SigNoz:main Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imrajdas @ankitnayan