Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: react is updated to v18 #1948

Merged
merged 19 commits into from Jan 4, 2023
Merged

feat: react is updated to v18 #1948

merged 19 commits into from Jan 4, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Dec 30, 2022 •
edited

@palashgdev palashgdev marked this pull request as draft December 30, 2022 07:30
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added enhancement New feature or request codeball:needs-careful-review Codeball labels Dec 30, 2022
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@pranay01
Copy link
Collaborator

@palashgdev So this PR should be tested only after #1880 is merged right?

@palashgdev
Copy link
Contributor Author

@palashgdev So this PR should be tested only after #1880 is merged right?

Yes

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

palashgdev and others added 2 commits January 4, 2023 13:28
@palashgdev @pranay01
feat: antdv5 is updated (#1880)
b55587c 
* feat: v5 is in progress

* feat: antdv5 is updated

* fix: build is fixed

* fix: default config is over written by custom one

* chore: onchange handler is updated

* chore: overflow is hidden in the layout

* Update index.tsx

* fix: import is fixed

* chore: un used import is fixed

* fix: dark mode is updated in service map

* fix: config dropdown is updated

* fix: logs types is updated

* fix: copy clipboard notification is updated

Co-authored-by: Pranay Prateek <pranay@signoz.io>
@palashgdev
chore: changes are updated
9287d11
@palashgdev palashgdev marked this pull request as ready for review January 4, 2023 08:15
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev palashgdev self-assigned this Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

pranay01
pranay01 previously approved these changes Jan 4, 2023
View reviewed changes
Copy link
Collaborator

@pranay01 pranay01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality wise, the PR looks fine. Though to me there seems to be increase in loading time. If that is not due to this PR, then we should be good to go.

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ankitnayan
Copy link
Collaborator

@palashgdev the build pipeline seems to be failing

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev
Copy link
Contributor Author

@palashgdev the build pipeline seems to be failing

fixed

@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ankitnayan ankitnayan merged commit 1c7202b into develop Jan 4, 2023
@github-actions
Copy link

github-actions bot commented Jan 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ankitnayan ankitnayan deleted the reactv18 branch January 4, 2023 17:28
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ankitnayan added a commit that referenced this pull request Jan 6, 2023
@ankitnayan
Revert "feat: react is updated to v18 (#1948)"
7e64e23 
This reverts commit 1c7202b.
@ankitnayan ankitnayan mentioned this pull request Jan 6, 2023
Merged
ankitnayan added a commit that referenced this pull request Jan 6, 2023
@ankitnayan
Revert "feat: react is updated to v18 (#1948)" (#1990)
1f6fcb9 
This reverts commit 1c7202b.
@palashgdev palashgdev restored the reactv18 branch January 9, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pranay01 pranay01 pranay01 left review comments

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees

@palashgdev palashgdev

Labels
codeball:needs-careful-review Codeball enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@palashgdev @pranay01 @ankitnayan