chore: use a new port if existing port is in use #199
Conversation
rahulrana95
force-pushed
the
bug/open-new-port
branch
from
3b7d1f3
to
9279e1e
Compare
|
Good one for local development. But if it is running within a container/k8s, then it won't be required. |
yeah agree |
jyash97
changed the title
rahulrana95
force-pushed
the
bug/open-new-port
branch
from
c9d4f8c
to
fe77d2a
Compare
frontend/README.md
Outdated
| ```Note: Please ping us in #contributing channel in our slack community and we will DM you with <test environment URL>``` | ||
| ```Note: Please ping us in #contributing channel in our slack community and we will DM you with <test environment URL>``` | ||
|
|
||
| ### To Avoid Adding a file to git or ignore changes |
There was a problem hiding this comment.
Not sure, if we need this instructions.
There was a problem hiding this comment.
@jyash97 this is good to know instruct=ions when you want to avoid changs adding to a file
There was a problem hiding this comment.
I agree this is good to know instructions. But usually project doesnt include git instructions to remove files.
On other note: I have never used this till now 😅
cc @nidhi-tandon @ankitnayan what are your thoughts?
There was a problem hiding this comment.
this is not to remove files, for example if you make changes in locale .env files then you dont need to commit them as they are locale
so what you can do ignore them, so any changes you do will not be added to commit
There was a problem hiding this comment.
README.md should contain info about the projects. Usually, OSS projects have 2 sets of users engaged a) OSS users, and b) OSS developers. The above info seems useful for b) type users. I guess README.md is more focussed on a) type users and CONTRIBUTING.md on b) type users.
Got a nice article on README.md at link. Feel free to emphasize a few points which seem good.
|
@rahulrana95 On running I did Want to change the registry from uberinternal to yarnpkg? |
|
@rahulrana95 I see conflicting files. Can you update your branch with the latest main and push again? |
Currently we are using by default 3000 port.
So if that port is being used it will not throw error or open anything else.
Added a new library so it will search if 3000 not available then open new port in browser.