Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: global time is updated #2013

Merged
merged 30 commits into from
Feb 2, 2023
Merged

feat: global time is updated #2013

merged 30 commits into from
Feb 2, 2023

Conversation

palashgdev
Copy link
Contributor

Close #1915

nityanandagohain
nityanandagohain reviewed Jan 11, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Go to latest is working fine

@ankitnayan
Copy link
Collaborator

@palashgdev do the start and end refresh on any action to the searchbox? Either from close or search button. Or searchbox dropdown builder or any filtering done by selecting a selected field. If not, we should refresh on such actions

@palashgdev palashgdev marked this pull request as draft January 13, 2023 15:49
@palashgdev palashgdev marked this pull request as ready for review January 22, 2023 12:01
@srikanthccv srikanthccv self-assigned this Jan 24, 2023
@srikanthccv
Copy link
Member

@palashgdev couple of things while checking with the latest dev

@palashgdev palashgdev marked this pull request as draft January 25, 2023 10:35
@palashgdev palashgdev marked this pull request as ready for review January 31, 2023 11:14
nityanandagohain
nityanandagohain reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality Test

  • Prev/Next should not update time
  • Filtering by clicking on the UI updates time range
  • Search updates the time range
  • Interesting/selected field doesn't update time range.
  • Go to the latest updates the time range

But if I am on nth page, by clicking prev and next I think we should not update timerange if users filter by clicking on the ui. But it might be hard to implement.
I think with this release we can go ahead with these changes and see how our users react. cc @ankitnayan

@palashgdev let me know if there is anything else to test

@sonarcloud
Copy link

sonarcloud bot commented Feb 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev palashgdev merged commit 17f32e9 into SigNoz:develop Feb 2, 2023
@palashgdev palashgdev mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@ankitnayan ankitnayan Awaiting requested review from ankitnayan

Assignees

@srikanthccv srikanthccv

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update start and end timestamps in logs page on a few actions
5 participants
@palashgdev @ankitnayan @srikanthccv @nityanandagohain @makeavish