Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme.md is updated #209

Merged
merged 1 commit into from Jul 5, 2021
Merged

readme.md is updated #209

merged 1 commit into from Jul 5, 2021

Conversation

palashgupta98
Copy link
Contributor

In this PR How to run the frontend locally with docker and without docker is updated

@palashgupta98
Copy link
Contributor Author

@ankitnayan @nidhi-tandon @rahulrana95

@ankitnayan ankitnayan merged commit 7de1737 into SigNoz:main Jul 5, 2021
jyash97
jyash97 reviewed Jul 5, 2021
View reviewed changes
Copy link
Contributor

@jyash97 jyash97 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should move the local setup instructions to a separate file called CONTRIBUTING.md. Readme can be used to add details about the frontend app like what it does and how it was bootstrapped

@stnert stnert mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyash97 jyash97 jyash97 left review comments

@rahulrana95 rahulrana95 rahulrana95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@palashgupta98 @rahulrana95 @jyash97 @ankitnayan