Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: color encoding is added in the logs raw view #2398

Merged
merged 4 commits into from
Feb 28, 2023
Merged

feat: color encoding is added in the logs raw view #2398

merged 4 commits into from
Feb 28, 2023

Conversation

palashgdev
Copy link
Contributor

part of #2298

For RAW Logs

  1. added the support of encoding the text to ansi
  2. sanitise the html (before adding it to the dom)

Screenshot 2023-02-27 at 12 45 59 PM

Screenshot 2023-02-27 at 12 46 13 PM

@palashgdev palashgdev added enhancement New feature or request frontend logs labels Feb 27, 2023
@palashgdev palashgdev self-assigned this Feb 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@palashgdev palashgdev added this to the v0.17.0 milestone Feb 27, 2023
nityanandagohain
nityanandagohain approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@palashgdev palashgdev merged commit 80cd317 into develop Feb 28, 2023
@ankitnayan ankitnayan deleted the 2298 branch September 10, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nityanandagohain nityanandagohain nityanandagohain approved these changes

Assignees

@palashgdev palashgdev

Labels
codeball:needs-careful-review Codeball enhancement New feature or request frontend logs
Projects
None yet
Milestone
v0.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@palashgdev @nityanandagohain