Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CODEOWNERS for */query-service/ #2421

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

srikanthccv
Copy link
Member

The approval from person with repo write access only count towards the requirement only If the author is also part of CODEOWNERS or the reviewer is part of the CODEOWNERS. The **/query-service signature matches both OSS and EE parts of query service.

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

github-actions[bot]
github-actions bot previously approved these changes Mar 3, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.95 | [dashboard]

@github-actions
Copy link

github-actions bot commented Mar 3, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot dismissed their stale review March 3, 2023 17:13

confidence: 0.66 | [dashboard]

@sonarcloud
Copy link

sonarcloud bot commented Mar 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ankitnayan ankitnayan merged commit e3fee33 into develop Mar 3, 2023
@ankitnayan ankitnayan deleted the self-add-ee branch March 3, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants