feat: add query builder to the alerts #2657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
github-actions
bot
added
enhancement
yeshev
force-pushed
the
feat/connect_builder_alerts
branch
3 times, most recently
from
54caa1c
to
332e988
Compare
yeshev
force-pushed
the
feat/connect_builder_graph
branch
from
d38647e
to
ec36cae
Compare
yeshev
force-pushed
the
feat/connect_builder_alerts
branch
from
332e988
to
cceaa74
Compare
…connect_builder_alerts # Conflicts: # frontend/src/container/FormAlertRules/ChartPreview/index.tsx # frontend/src/container/FormAlertRules/QuerySection.tsx # frontend/src/container/FormAlertRules/utils.ts # frontend/src/container/MetricsApplication/Tabs/DBCall.tsx # frontend/src/container/MetricsApplication/Tabs/External.tsx # frontend/src/container/MetricsApplication/Tabs/Overview.tsx # frontend/src/container/NewWidget/LeftContainer/QuerySection/types.ts # frontend/src/container/QueryBuilder/QueryBuilder.tsx # frontend/src/container/QueryBuilder/components/Query/Query.interfaces.ts # frontend/src/container/QueryBuilder/components/Query/Query.tsx # frontend/src/container/QueryBuilder/filters/HavingFilter/HavingFilter.tsx # frontend/src/hooks/queryBuilder/useQueryOperations.ts # frontend/src/lib/newQueryBuilder/queryBuilderMappers/mapQueryDataToApi.ts # frontend/src/providers/QueryBuilder.tsx # frontend/src/store/actions/dashboard/getQueryResults.ts # frontend/src/types/api/dashboard/getAll.ts # frontend/src/types/common/operations.types.ts
yeshev
force-pushed
the
feat/connect_builder_alerts
branch
from
47fe7f2
to
6235a79
Compare
yeshev
force-pushed
the
feat/connect_builder_alerts
branch
from
af9f35a
to
5dd0bd3
Compare
…connect_builder_alerts
|
Functionally this looks good to me. We can get this merged after Palash's approval and continue doing rigorous testing. |
…connect_builder_alerts
yeshev
force-pushed
the
feat/connect_builder_alerts
branch
from
e076550
to
4e7e003
Compare
yeshev
force-pushed
the
feat/connect_builder_alerts
branch
from
47a3409
to
7b3dfb3
Compare
* feat: add builder data to metric application * fix: query types to single variant * fix: formula legend formatting * fix: argumant name * fix: date for graph --------- Co-authored-by: Palash Gupta <palashgdev@gmail.com>
|
Functionality LGTM |
palashgdev
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.