[Fix]: Alert Channels breadcrumbs #2669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
|
We would appreciate it if you could provide us with more info about this issue/pr! |
ksorv
changed the title
srikanthccv
approved these changes
May 8, 2023
palashgdev
approved these changes
May 10, 2023
|
Thanks @ksorv for raising the fix :-D |
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2577
Issue was:
Changes:
settingsinstead ofsetting/settings/channelsroute to breadcrumbNameMapeditfrom route in favour ofsettings/channels/:id[yet to be reviewed]Video:
Screen.Recording.2023-05-05.at.10.59.43.PM.mov