Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove react import #2727

Merged
merged 7 commits into from
May 19, 2023

Conversation

GermaVinsmoke
Copy link
Contributor

@GermaVinsmoke GermaVinsmoke commented May 18, 2023

Added rule in eslint, .babelrc and tsconfig.json to make sure import React from 'react' is not needed.
Corrected all react imports.

Error is there in one file - src/container/QueryBuilder/filters/QueryBuilderSearch/index.tsx

Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>
Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>
Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>
Signed-off-by: GermaVinsmoke <vaibhav1180@gmail.com>
@GermaVinsmoke GermaVinsmoke changed the title Chore/remove react import chore: remove react import May 18, 2023
@palashgdev
Copy link
Contributor

much needed pr thanks @GermaVinsmoke i will review this one today

@palashgdev palashgdev merged commit 72452dc into SigNoz:develop May 19, 2023
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants