Feat/extend query builder state #2755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extend_query_builder_state # Conflicts: # frontend/src/lib/newQueryBuilder/queryBuilderMappers/mapQueryDataFromApi.ts
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
We would appreciate it if you could provide us with more info about this issue/pr! |
palashgdev
approved these changes
May 23, 2023
srikanthccv
reviewed
Jun 8, 2023
Comment on lines
-22
to
-28
| return { | ||
| rawQuery: rawQuery !== undefined ? rawQuery : src.query, | ||
| query: rawQuery !== undefined ? rawQuery : src.query, | ||
| legend: legend !== undefined ? legend : src.legend, | ||
| name: 'A', | ||
| disabled: false, | ||
| }; |
There was a problem hiding this comment.
Where is the equivalent of this in the new code? @palashgdev When such significant changes are getting merged, we need to ensure we do it carefully. Reviewing the functionality in the code (not from the UI testing) is important.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #2652
https://www.loom.com/share/b79c150f7a4442af912f671f54a840a4