fix: create and store label when colon is pressed #2886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
palashgdev
suggested changes
Jun 11, 2023
|
Hi @Damans227 |
palashgdev
approved these changes
Jun 12, 2023
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2692
When creating an Alert, the key value pair (label) field allows the user to include a colon in either key or value. It can cause confusion and lead users to believe the key and value must be included as one string in order to account for a label. This is exactly what caused #2692.
I would recommend that in addition to using
ENTERas a way to end a key or value string, we also allowCOLON (:)to do the same. In this way, the user will have a better experience. This screen recording shows how it works.