Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: step size is made dynamic #2903

Merged
merged 21 commits into from
Jun 28, 2023
Merged

fix: step size is made dynamic #2903

merged 21 commits into from
Jun 28, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Jun 14, 2023 •
edited
Loading

Close #2812
Close #2986

@github-actions github-actions bot added the bug Something isn't working label Jun 14, 2023
@srikanthccv
Copy link
Member

Will test the functionality locally.

@palashgdev
Copy link
Contributor Author

Will test the functionality locally.

sure :-D

@srikanthccv
Copy link
Member

  • breaks when you create a new dashboard and click on add a panel.
  • it doesn't work in panel edit mode. the stepInterval value is still sent as 30 for the builder query

@palashgdev
Copy link
Contributor Author

  • breaks when you create a new dashboard and click on add a panel.
  • it doesn't work in panel edit mode. the stepInterval value is still sent as 30 for the builder query

happened after merge from develop please re check

@srikanthccv
Copy link
Member

  • what's reflected in url, builder aggregate every is different from what's sent in API call
Screenshot 2023-06-17 at 6 05 58 AM

@palashgdev
Copy link
Contributor Author

  • what's reflected in url, builder aggregate every is different from what's sent in API call

my bad ... please re check

makeavish
makeavish previously approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@makeavish makeavish left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address this issue separately: #2931
LGTM, otherwise

@srikanthccv
Copy link
Member

I will test this again.

@srikanthccv
Copy link
Member

@palashgdev palashgdev marked this pull request as draft June 20, 2023 11:50
@palashgdev
Copy link
Contributor Author

glad you brought though this one as these new changes will make pr open again when things are clear

@palashgdev
Copy link
Contributor Author

as discussed offline updated the pr

  1. step for promQL would be powered from getStep
  2. from composite query followed the approach where min would be getting from getStep output and max user can enter there is no limit on that

@palashgdev palashgdev marked this pull request as ready for review June 26, 2023 09:10
@srikanthccv
Copy link
Member

https://www.loom.com/share/85baf5c78366479aaf2ba405171d300a

@palashgdev
Copy link
Contributor Author

https://www.loom.com/share/85baf5c78366479aaf2ba405171d300a

updated @srikanthccv

@srikanthccv
Copy link
Member

I think this was the only issue I could find, let me check again.

@palashgdev palashgdev merged commit 9b8f7a0 into develop Jun 28, 2023
9 of 11 checks passed
@palashgdev palashgdev deleted the 2812 branch June 28, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set default aggregation interval to 60 Dashboard slow to render for time intervals >1wk
3 participants
@palashgdev @srikanthccv @makeavish