Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updating dashboard variables is not allowed for viewer role #2910

Merged
merged 4 commits into from
Jun 15, 2023

Conversation

palashgdev
Copy link
Contributor

Close #2909

@github-actions github-actions bot added bug Something isn't working codeball:approved Codeball labels Jun 14, 2023
github-actions[bot]
github-actions bot previously approved these changes Jun 14, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codeball: LGTM! 👍

confidence: 0.97 | [dashboard]

@github-actions github-actions bot dismissed their stale review June 15, 2023 05:46

confidence: 0.27 | [dashboard]

@prashant-shahi prashant-shahi merged commit 9aa8148 into develop Jun 15, 2023
10 of 11 checks passed
@prashant-shahi prashant-shahi deleted the 2909 branch June 15, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working codeball:needs-careful-review Codeball
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: In viewer permission don't send the dashboard variables request but update the view
2 participants