Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ability to configure noisy top level operations to discard #2978

Merged
merged 4 commits into from
Jun 30, 2023
Merged

feat: ability to configure noisy top level operations to discard #2978

merged 4 commits into from
Jun 30, 2023

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jun 27, 2023 •
edited
Loading

Adds a config option --skip-top-level-ops to skip certain top-level operations for each service.

The sample config looks like the following.

services:
  - name: redis
    operations:
      - GetDriver

We need service wise config because what might be incorrect top-level operation options could be a correct top-level operation in another service. These are discarded from the call GetTopLevelOperations so that it reflects everywhere.

@request-info
Copy link

request-info bot commented Jun 27, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jun 27, 2023
@srikanthccv srikanthccv marked this pull request as ready for review June 29, 2023 07:57
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@ankitnayan ankitnayan self-requested a review June 29, 2023 10:22
@srikanthccv srikanthccv merged commit 20687d5 into develop Jun 30, 2023
9 of 10 checks passed
@srikanthccv srikanthccv deleted the skip-top-lvl-operations branch June 30, 2023 01:28
@srikanthccv srikanthccv mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@makeavish makeavish Awaiting requested review from makeavish

Assignees
No one assigned
Labels
enhancement New feature or request request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@srikanthccv @ankitnayan