Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow limit on metrics time series result #2979

Merged
merged 11 commits into from
Jul 13, 2023
Merged

Conversation

srikanthccv
Copy link
Member

@srikanthccv srikanthccv commented Jun 27, 2023

Part of #2845

@request-info
Copy link

request-info bot commented Jun 27, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jun 27, 2023
@srikanthccv srikanthccv marked this pull request as ready for review July 7, 2023 04:18
@srikanthccv
Copy link
Member Author

Please review or let me know if there is something I could have done to avoid no reviews for three days.

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From #2845 (comment) . I understood how you are trying to solve it, but a little test on the sorting and filtering logic will help.

pkg/query-service/app/http_handler.go Show resolved Hide resolved
@srikanthccv srikanthccv merged commit 08d496e into develop Jul 13, 2023
9 of 10 checks passed
@srikanthccv srikanthccv deleted the limit-time-series branch July 13, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request request-more-info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants