Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the Metric Application Layer #2984

Merged
merged 45 commits into from
Jul 13, 2023
Merged

Refactor the Metric Application Layer #2984

merged 45 commits into from
Jul 13, 2023

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented Jun 27, 2023 •
edited by srikanthccv
Loading

Fixes #2974

  • Removed the unnecessary dependency on the redux for storing metrics
  • Removed the API dependency for fetching top-operation, service-overview, and top-level-operation.

palashgdev
palashgdev suggested changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@palashgdev palashgdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done the code review need to check from functionality perspective

frontend/src/api/ErrorResponseHandler.ts Outdated Show resolved Hide resolved
frontend/src/api/metrics/getServiceOverview.ts Show resolved Hide resolved
frontend/src/api/metrics/getTopLevelOperations.ts Show resolved Hide resolved
frontend/src/api/metrics/getTopLevelOperations.ts Outdated Show resolved Hide resolved
frontend/src/api/metrics/getTopLevelOperations.ts Outdated Show resolved Hide resolved
frontend/src/container/MetricsApplication/Tabs/Overview.tsx Outdated Show resolved Hide resolved
frontend/src/container/MetricsApplication/Tabs/Overview.tsx Outdated Show resolved Hide resolved
frontend/src/container/MetricsApplication/Tabs/Overview.tsx Outdated Show resolved Hide resolved
frontend/src/lib/dashbaordVariables/getDashboardVariables.ts Outdated Show resolved Hide resolved
frontend/src/pages/MetricApplication/index.tsx Outdated Show resolved Hide resolved
@palashgdev
Copy link
Contributor

also build pipeline is breaking

@Rajat-Dabade Rajat-Dabade self-assigned this Jul 5, 2023
@palashgdev
Copy link
Contributor

@Rajat-Dabade can you check

TypeError: Cannot destructure property 'data' of 'selectedDashboard' as it is undefined.

@Rajat-Dabade
Copy link
Contributor Author

@palashgdev, this was because of this issue #2996.

@palashgdev
Copy link
Contributor

function MetricsApplication(): JSX.Element {

this is resolved as this was the issue on my end

palashgdev
palashgdev suggested changes Jul 12, 2023
View reviewed changes
frontend/src/store/reducers/global.ts Outdated Show resolved Hide resolved
frontend/src/pages/MetricApplication/index.tsx Outdated Show resolved Hide resolved
frontend/src/pages/MetricApplication/index.tsx Outdated Show resolved Hide resolved
frontend/src/container/MetricsApplication/Tabs/Overview.tsx Outdated Show resolved Hide resolved
palashgdev
palashgdev previously approved these changes Jul 13, 2023
View reviewed changes
@palashgdev palashgdev self-requested a review July 13, 2023 09:39
@palashgdev palashgdev merged commit 98745fc into SigNoz:develop Jul 13, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashgdev palashgdev palashgdev approved these changes

Assignees

@Rajat-Dabade Rajat-Dabade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

top operations blocks rendering of other charts in ServiceOverview page
3 participants
@Rajat-Dabade @palashgdev @srikanthccv