Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/list infinity scroll #2992

Merged
merged 18 commits into from
Jul 6, 2023
Merged

Feat/list infinity scroll #2992

merged 18 commits into from
Jul 6, 2023

Conversation

yeshev
Copy link
Contributor

@yeshev yeshev commented Jun 28, 2023

No description provided.

@yeshev yeshev self-assigned this Jun 28, 2023
@yeshev yeshev requested a review from palashgdev as a code owner June 28, 2023 11:59
@request-info
Copy link

request-info bot commented Jun 28, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Jun 28, 2023
@yeshev yeshev force-pushed the feat/list_infinity_scroll branch from 9d6ba0a to 1fe3a2a Compare June 28, 2023 12:00
@yeshev yeshev force-pushed the feat/list_infinity_scroll branch from 1fe3a2a to c82e3bd Compare June 28, 2023 12:37
yeshev and others added 3 commits June 29, 2023 14:34
@yeshev
feat: add infinity table view
68830ba
@yeshev
Fix/double query logs request (#3006)
ddb131c 
* feat: add control panel

* fix: repeating query api request
@yeshev
Merge branch 'develop' of https://github.com/SigNoz/signoz into feat/…
f5b9eb3 
…list_infinity_scroll

# Conflicts:
#	frontend/src/container/GridGraphLayout/WidgetHeader/index.tsx
#	frontend/src/container/ListAlertRules/ListAlert.tsx
#	frontend/src/container/LogsExplorerViews/index.tsx
#	frontend/src/container/NewDashboard/ComponentsSlider/index.tsx
#	frontend/src/container/QueryBuilder/filters/OrderByFilter/OrderByFilter.tsx
#	frontend/src/hooks/queryBuilder/useGetCompositeQueryParam.ts
#	frontend/src/pages/TracesExplorer/index.tsx
#	frontend/src/providers/QueryBuilder.tsx
@makeavish
Copy link
Member

@yeshev One UI issue
https://share.vidyard.com/watch/NVgD1EHoX1mf7JmGnGTEJJ?

@makeavish
Copy link
Member

Timestamp invalid

Screenshot 2023-07-03 at 19 07 05

@makeavish
Copy link
Member

View details button not working
Screenshot 2023-07-03 at 19 07 05

nityanandagohain
nityanandagohain requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Option to select pagesize should be removed -> Frontend should store 100 as the value of pageSize in contants and use it in the API.

  • Id filter used for pagination should be hidden from the UI. Now when we paginate by scrolling the id filter appears in the filter box

  • Extra scrollbar should be removed from the logs view, when we paginate an extra scrollbar appears on the left which should not be there, only the scrollbar from the browser should be present

@yeshev yeshev force-pushed the feat/list_infinity_scroll branch from 6ae074a to 84091ff Compare July 4, 2023 10:25
nityanandagohain
nityanandagohain requested changes Jul 4, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • offset should start from 0 and not 1, when using different orderby

@yeshev
Copy link
Contributor Author

yeshev commented Jul 4, 2023

  • Option to select pagesize should be removed -> Frontend should store 100 as the value of pageSize in contants and use it in the API.
  • Id filter used for pagination should be hidden from the UI. Now when we paginate by scrolling the id filter appears in the filter box
  • Extra scrollbar should be removed from the logs view, when we paginate an extra scrollbar appears on the left which should not be there, only the scrollbar from the browser should be present

@nityanandagohain I've fixed it. Check it please

nityanandagohain
nityanandagohain requested changes Jul 5, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Infinite scrolling has stopped working, new api calls doesn't seems to be triggered on reaching the end of the page

offset should start from 0 and not 1, when using different orderby other than timestamp

Please add this change as well

@yeshev
fix: reset offset to 0
a7f5b28
@yeshev
Merge branch 'develop' of https://github.com/SigNoz/signoz into feat/…
63ae488 
…list_infinity_scroll

# Conflicts:
#	frontend/src/container/OptionsMenu/useOptionsMenu.ts
@yeshev
Copy link
Contributor Author

yeshev commented Jul 5, 2023

  • offset should start from 0 and not 1, when using different orderby

@nityanandagohain I've just fixed it also

@yeshev
Copy link
Contributor Author

yeshev commented Jul 5, 2023

  • Infinite scrolling has stopped working, new api calls doesn't seems to be triggered on reaching the end of the page

offset should start from 0 and not 1, when using different orderby other than timestamp

Please add this change as well

@nityanandagohain Also fixed it in last commit

@nityanandagohain
Copy link
Member

  • Set limit to 100000 only for list View
  • Timeseries and table keep limit 100
  • Use correct operator in timestamp asc and timestamp desc

yeshev and others added 3 commits July 5, 2023 15:13
@yeshev @makeavish
feat: add log explorer detail (#3007)
c314552 
* feat: add control panel

* fix: repeating query api request

* feat: add log explorer detail

---------

Co-authored-by: Vishal Sharma <makeavish786@gmail.com>
@yeshev
feat: add group by in the logs chart (#3009)
996bb65 
* feat: add control panel

* fix: repeating query api request

* feat: add log explorer detail

* feat: add group by in the logs chart
@yeshev
fix: list timestamp, limit, filter order
e087dd4
nityanandagohain
nityanandagohain reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes looks good, please resolve the conflicts and they are good to merge

yeshev and others added 2 commits July 6, 2023 10:54
@yeshev
feat: add list chart (#3037)
c3ee4db 
* feat: add list chart

* refactor: remove console log
@yeshev
Merge branch 'develop' of https://github.com/SigNoz/signoz into feat/…
f617050 
…list_infinity_scroll

# Conflicts:
#	frontend/src/container/QueryBuilder/filters/OrderByFilter/OrderByFilter.tsx
#	frontend/src/container/TimeSeriesView/index.tsx
@yeshev
feat: hide aggregate every for table view (#3046)
5bed54a 
* feat: hide aggregate every for table view

* fix: text filter for inactive filters

* refactor: remove log

* fix: table columns
@makeavish
Copy link
Member

makeavish commented Jul 6, 2023 •
edited
Loading

Some feedbacks for this PR:
@yeshev You can create a separate PR for these issues.

  1. Add new columns to the end of table in list view of logs explorer #3049
  2. Preserve logs list view state/options #3050
  3. Don't show add a column in Row format #3051
  4. Unable to delete a column even though there are 2 columns #3052
  5. Similar issues exists in logs as well: Make tag attributes API call on when user tries to add a column in trace explorer page list view #3031

@ankitnayan ankitnayan merged commit 76ba364 into develop Jul 6, 2023
8 of 11 checks passed
@ankitnayan ankitnayan deleted the feat/list_infinity_scroll branch July 6, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

@nityanandagohain nityanandagohain nityanandagohain approved these changes

@palashgdev palashgdev Awaiting requested review from palashgdev

Assignees

@yeshev yeshev

Labels
enhancement New feature or request request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yeshev @makeavish @nityanandagohain @ankitnayan