Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export panel in logs explorer is added #2993

Merged
merged 9 commits into from
Jul 7, 2023
Merged

feat: export panel in logs explorer is added #2993

merged 9 commits into from
Jul 7, 2023

Conversation

palashgdev
Copy link
Contributor

Close #2346

@github-actions github-actions bot added the enhancement New feature or request label Jun 28, 2023
@palashgdev palashgdev self-assigned this Jun 28, 2023
makeavish
makeavish requested changes Jul 3, 2023
View reviewed changes
Copy link
Member

@makeavish makeavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two issues:

  1. Panel is not exported. Just a new dashboard is created
  2. Error not shown when exporting is failed due to feature limit exceeded

@palashgdev
Copy link
Contributor Author

palashgdev commented Jul 3, 2023 •
edited
Loading

Two issues:

  1. Panel is not exported. Just a new dashboard is created

  2. Error not shown when exporting is failed due to feature limit exceeded

  1. panel will be removed if not clicked on save button as this is removed when user moved to widget list page

  2. this is client side navigation individual page are already handling this issue

though above mentioned are not issue

@makeavish makeavish linked an issue Jul 7, 2023 that may be closed by this pull request
Show appropriate error on feature limit exceeded while exporting panel #3013
Closed
@makeavish
Copy link
Member

Gap between action and run query on logs explorer is higher.
Please reduce it. Check trace explorer for reference
Screenshot 2023-07-07 at 18 03 22

@makeavish
Copy link
Member

@yeshev Found a bug
https://www.loom.com/share/6157097417f6487fa9bf76408a32420f?sid=e199c0f8-8f3c-42fd-b1b6-508a05724bcc

@makeavish
Copy link
Member

@yeshev Another issue:
https://www.loom.com/share/0432aa899b7641d4be850506cf5a0065?sid=2822f438-ad05-4fcb-9f26-a531a857b79c
This is common for alerts and panel export.
I think solution would be to switch from Noop to count when exporting from list/trace view

@makeavish
Copy link
Member

Another issue:
Aggregate operator is not exported in alert export
https://www.loom.com/share/0004e1965e1b4de1a1f196a48b9a46eb?sid=0ae8f426-a67c-4325-aff9-746fe754d0f1

@yeshev
Copy link
Contributor

yeshev commented Jul 7, 2023

@yeshev Another issue: https://www.loom.com/share/0432aa899b7641d4be850506cf5a0065?sid=2822f438-ad05-4fcb-9f26-a531a857b79c This is common for alerts and panel export. I think solution would be to switch from Noop to count when exporting from list/trace view

@makeavish fixed

@yeshev
Copy link
Contributor

yeshev commented Jul 7, 2023

Another issue: Aggregate operator is not exported in alert export https://www.loom.com/share/0004e1965e1b4de1a1f196a48b9a46eb?sid=0ae8f426-a67c-4325-aff9-746fe754d0f1

Fixed

@ankitnayan ankitnayan merged commit 2e85bd0 into develop Jul 7, 2023
9 of 11 checks passed
@ankitnayan ankitnayan deleted the 2346 branch July 7, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

Assignees

@palashgdev palashgdev

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
4 participants
@palashgdev @makeavish @yeshev @ankitnayan