Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: minor fixes to logs QB #3022

Merged
merged 4 commits into from
Jul 4, 2023
Merged

feat: minor fixes to logs QB #3022

merged 4 commits into from
Jul 4, 2023

Conversation

nityanandagohain
Copy link
Member

@nityanandagohain nityanandagohain commented Jul 4, 2023 •
edited
Loading

  • Was returning wrong variable in enrich funtion
  • Timestamp order by should not be added when a custom order by is selected in list panel
  • Previous logic of order by was added under the impression that timestamp can come in order by for aggregation -> but it won’t come since timestamp won’t be there in group by

@github-actions github-actions bot added bug Something isn't working enhancement New feature or request labels Jul 4, 2023
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain marked this pull request as ready for review July 4, 2023 12:35
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link

github-actions bot commented Jul 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain merged commit 193b04f into develop Jul 4, 2023
9 of 11 checks passed
@nityanandagohain nityanandagohain deleted the feat/logs-minor-fixes branch July 4, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makeavish makeavish makeavish approved these changes

@srikanthccv srikanthccv srikanthccv approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nityanandagohain @makeavish @srikanthccv