-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for table view in traces #3047
Conversation
Address the points related to this from this issue #3095 or anything else that is not covered. |
What is the reasoning? That doesn't make sense to me because this PR is adding support for the table view in traces and it is incomplete knowing something is not working. You could address it separately for other panel types. |
Please check this with the formula. I suspect it will break because the formula needs a join key. One way I workaround this in metrics is by adding |
Those changes are not related to table view changes. The issue existed previously in the function common for time-series and table view. |
If it was mentioned that the issue exists within the reader.go then it would have been easier to see why it made sense to think about addressing separately. Otherwise, it's not clear where the issue exists and why it should be addressed separately. |
Addressed with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the tests
Updated. |
closes(#2861)