Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for table view in traces #3047

Merged
merged 14 commits into from
Jul 12, 2023
Merged

Conversation

makeavish
Copy link
Member

@makeavish makeavish commented Jul 6, 2023

closes(#2861)

@github-actions github-actions bot added the enhancement New feature or request label Jul 6, 2023
@makeavish makeavish linked an issue Jul 6, 2023 that may be closed by this pull request
@srikanthccv
Copy link
Member

Address the points related to this from this issue #3095 or anything else that is not covered.

@makeavish
Copy link
Member Author

Address the points related to this from this issue #3095 or anything else that is not covered.

Points related to issue #3095 will be addressed separately.

@srikanthccv
Copy link
Member

What is the reasoning? That doesn't make sense to me because this PR is adding support for the table view in traces and it is incomplete knowing something is not working. You could address it separately for other panel types.

@srikanthccv
Copy link
Member

Please check this with the formula. I suspect it will break because the formula needs a join key. One way I workaround this in metrics is by adding now() for the timestamp so the ts is there for the sake of JOIN and still produces the correct result.

@makeavish
Copy link
Member Author

What is the reasoning? That doesn't make sense to me because this PR is adding support for the table view in traces and it is incomplete knowing something is not working. You could address it separately for other panel types.

Those changes are not related to table view changes. The issue existed previously in the function common for time-series and table view.

@srikanthccv
Copy link
Member

If it was mentioned that the issue exists within the reader.go then it would have been easier to see why it made sense to think about addressing separately. Otherwise, it's not clear where the issue exists and why it should be addressed separately.

@makeavish
Copy link
Member Author

Please check this with the formula. I suspect it will break because the formula needs a join key. One way I workaround this in metrics is by adding now() for the timestamp so the ts is there for the sake of JOIN and still produces the correct result.

Addressed with now() as ts.
@srikanthccv

Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests

@makeavish
Copy link
Member Author

Please update the tests

Updated.

@makeavish makeavish merged commit 39c6410 into develop Jul 12, 2023
9 of 10 checks passed
@makeavish makeavish deleted the feat/support-table-view branch July 12, 2023 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(traces): add support for table panel type
3 participants