Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add converting to ms for the durationNano attribute #3072

Merged
merged 5 commits into from
Jul 7, 2023

Conversation

dnazarenkoo
Copy link
Contributor

No description provided.

@request-info
Copy link

request-info bot commented Jul 7, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@makeavish
Copy link
Member

@dnazarenkoo
Can you please also show ms in values?
Screenshot 2023-07-07 at 17 50 26

@makeavish makeavish linked an issue Jul 7, 2023 that may be closed by this pull request
@dnazarenkoo
Copy link
Contributor Author

@dnazarenkoo Can you please also show ms in values? Screenshot 2023-07-07 at 17 50 26

fixed

Copy link
Member

@makeavish makeavish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to support this for table view as well but that can be done in another PR.
Issue will stay open for table view: #3042

@ankitnayan ankitnayan merged commit 2b3934b into SigNoz:develop Jul 7, 2023
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants