Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proper formatting for noop operator in logs #3086

Merged
merged 3 commits into from
Jul 11, 2023

Conversation

nityanandagohain
Copy link
Member

So it corrects.

where (timestamp >= 1688985789000000000 AND timestamp <= 1688987580000000000) AND level = 'info'order by timestamp desc

to
where (timestamp >= 1688985789000000000 AND timestamp <= 1688987580000000000) AND level = 'info' order by timestamp desc

previously it went unnoticed because clickhouse doesn't throw error for
level = 'info'order by timestamp desc
while it throws error for
severity_number = 0order by timestamp desc

@github-actions github-actions bot added the bug Something isn't working label Jul 10, 2023
@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@nityanandagohain nityanandagohain merged commit c51a15f into develop Jul 11, 2023
8 of 9 checks passed
@nityanandagohain nityanandagohain deleted the feat/logs-formatting-noop branch July 11, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants