Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table view on click is now taking raw logs #3153

Merged
merged 5 commits into from
Jul 17, 2023
Merged

fix: table view on click is now taking raw logs #3153

merged 5 commits into from
Jul 17, 2023

Conversation

palashgdev
Copy link
Contributor

Close #3113

@palashgdev palashgdev self-assigned this Jul 17, 2023
@github-actions github-actions bot added the bug Something isn't working label Jul 17, 2023
@palashgdev palashgdev added frontend logs bug Something isn't working and removed bug Something isn't working labels Jul 17, 2023
Copy link
Member

@nityanandagohain nityanandagohain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes looks good, @palashgdev we also discussed regarding how the contents are displayed i.e in the old details page timestamp is always at the top then id etc. But it is not present in the new detail page. Do you want to address it in this same PR ?

@palashgdev
Copy link
Contributor Author

This changes looks good, @palashgdev we also discussed regarding how the contents are displayed i.e in the old details page timestamp is always at the top then id etc. But it is not present in the new detail page. Do you want to address it in this same PR ?

different PR please make a issue for same

@palashgdev palashgdev merged commit 0beffb5 into develop Jul 17, 2023
9 of 11 checks passed
@palashgdev palashgdev deleted the 3113 branch July 17, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FE: [LOGS] Details page inconsistent
2 participants