Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable limit on ts (traces) #3157

Merged
merged 8 commits into from
Jul 19, 2023
Merged

feat: enable limit on ts (traces) #3157

merged 8 commits into from
Jul 19, 2023

Conversation

makeavish
Copy link
Member

closes(#2845)

@makeavish makeavish changed the title feat: enable limit on ts feat: enable limit on ts (traces) Jul 17, 2023
@github-actions github-actions bot added the enhancement New feature or request label Jul 17, 2023
@makeavish makeavish mentioned this pull request Jul 18, 2023
Closed
srikanthccv
srikanthccv reviewed Jul 18, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, few questions.

pkg/query-service/app/traces/v3/query_builder.go Outdated Show resolved Hide resolved
pkg/query-service/app/queryBuilder/query_builder.go Outdated Show resolved Hide resolved
@makeavish makeavish merged commit 5a2a987 into develop Jul 19, 2023
9 of 10 checks passed
@makeavish makeavish deleted the feat/add-limit-support-trace branch July 19, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@nityanandagohain nityanandagohain Awaiting requested review from nityanandagohain

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@makeavish @srikanthccv @nityanandagohain