Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ordering of ts and table panel #3163

Merged
merged 4 commits into from
Jul 18, 2023
Merged

fix: ordering of ts and table panel #3163

merged 4 commits into from
Jul 18, 2023

Conversation

makeavish
Copy link
Member

@makeavish makeavish commented Jul 17, 2023 •
edited
Loading

closes(#3095)

Order of result was not ensured as we were iterating over a map.
Changed the map to slice and also removed duplicates from the slice.

@github-actions github-actions bot added the bug Something isn't working label Jul 17, 2023
@makeavish makeavish linked an issue Jul 17, 2023 that may be closed by this pull request
Order By doesn't work consistently in timeseries/table view #3095
Closed
srikanthccv
srikanthccv approved these changes Jul 18, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@makeavish makeavish merged commit 49afc25 into develop Jul 18, 2023
9 of 10 checks passed
@makeavish makeavish deleted the fix/ordering-table-panel branch July 18, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@nityanandagohain nityanandagohain Awaiting requested review from nityanandagohain

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Order By doesn't work consistently in timeseries/table view
2 participants
@makeavish @srikanthccv