Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove having filter #3219

Merged
merged 5 commits into from
Jul 28, 2023
Merged

Conversation

vasukapil
Copy link
Contributor

@vasukapil vasukapil commented Jul 27, 2023

close #3193

@palashgdev This solves the conflicts and removes Having filter from logs and traces for list view.

@palashgdev
Copy link
Contributor

@palashgdev This solves the conflicts and removes Having filter from logs and traces for list view.

if we are solving the conflicts we don't raise the new pr we solve in the existing one 😅 but anyway let me check

@vasukapil
Copy link
Contributor Author

@palashgdev This solves the conflicts and removes Having filter from logs and traces for list view.

if we are solving the conflicts we don't raise the new pr we solve in the existing one 😅 but anyway let me check

@palashgdev Yes,but yesterday when I fork sync my repo so that I can get the updated changes from the develop branch.This PR got closed I don't know what exactly the reason was.

@palashgdev palashgdev merged commit 4753868 into SigNoz:develop Jul 28, 2023
8 of 11 checks passed
@welcome
Copy link

welcome bot commented Jul 28, 2023

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Having filter in list view of logs and traces explorer
3 participants