feat: show page name in document title using React Helmet #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palashgdev
reviewed
Jul 30, 2023
palashgdev
reviewed
Jul 30, 2023
|
thanks, @mustajab-ikram for the PR just small chances would be good to have |
|
fix: Add translation support for page titles
|
palashgdev
approved these changes
Aug 2, 2023
There was a problem hiding this comment.
thanks @mustajab-ikram for raising the pr
small, enhancement which I did updated the return type of the function and we already have AppLayout so move the logic there
And thanks for sharing the pr :-D working seamlessly
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed the task related to Issue #3201. I have added the Page Title functionality using React Helmet as discussed in our previous chats.
Please take a look at the PR when you get a chance. Let me know if there are any further changes or improvements you would like to see.
close #3201