feat: limit offset logic updated for logs list view #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't understand from the issue/PR description why it doesn't work. Please help me understand the issue. |
|
So we didn't handle how limit should work when the order by is timestamp, this PR handles this. So now the frontend has to send limit and offset as well for order by timestamp. Also it handles the edge cases were limit is less that pagesize or the last page where actual values returned to should be limit-offset instead of pagesize |
srikanthccv
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3242
This PR adds changes such that limit offset works for both ordering with timestamp and ordering with custom key.