Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new dashboard page is updated #3385

Merged
merged 52 commits into from
Oct 8, 2023
Merged

feat: new dashboard page is updated #3385

merged 52 commits into from
Oct 8, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Aug 18, 2023 •
edited by ankitnayan
Loading

part of #3361

Screen.Recording.2023-08-24.at.6.28.23.PM.mov

few changes to address as whole new architecture for the page is achieved

  1. Save Layout
  2. Add Panel
  3. Resizing the widget does not call the save api
  4. While adding the panel there is no api call to save the EMPTY_WIDGET
  5. Panels limited to show 20 timeseries (lines) and shows a warning in the panel
  6. Asks to reload if the dashboard is changed from another client, eg, another tab

@palashgdev palashgdev requested a review from a team August 18, 2023 19:11
@github-actions github-actions bot added the enhancement New feature or request label Aug 18, 2023
@palashgdev palashgdev self-assigned this Aug 18, 2023
@palashgdev palashgdev changed the title feat: dashboard widget page is refactored feat: new dashboard page is updated Aug 24, 2023
@palashgdev palashgdev marked this pull request as ready for review August 24, 2023 06:01
Rajat-Dabade
Rajat-Dabade reviewed Aug 25, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change, everything else LGTM 🚀

CKanishka
CKanishka suggested changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@CKanishka CKanishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor refactoring changes

CKanishka
CKanishka previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@CKanishka CKanishka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Rajat-Dabade
Rajat-Dabade previously approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palashgdev palashgdev dismissed stale reviews from CKanishka and Rajat-Dabade via 5f08460 August 30, 2023 16:01
@srikanthccv srikanthccv self-requested a review September 3, 2023 10:21
@palashgdev
Copy link
Contributor Author

palashgdev commented Sep 4, 2023 •
edited
Loading

@srikanthccv in this PR , migration would be from the backend in which the layout id is empty which needs to be EMPTY_WIDGET

srikanthccv
srikanthccv previously approved these changes Sep 5, 2023
View reviewed changes
@palashgdev palashgdev temporarily deployed to testing October 4, 2023 15:18 — with GitHub Actions Inactive
makeavish
makeavish previously approved these changes Oct 6, 2023
View reviewed changes
@makeavish
Copy link
Member

Their may be some lag in opening of dashboard: https://www.loom.com/share/644af6931cc1443388c70d7e64601c20?sid=d5169d36-1a0b-4479-ae57-5c9294b13211

@ankitnayan ankitnayan self-requested a review October 8, 2023 05:32
ankitnayan
ankitnayan previously approved these changes Oct 8, 2023
View reviewed changes
@ankitnayan ankitnayan self-requested a review October 8, 2023 17:50
@ankitnayan ankitnayan merged commit e7a5eb7 into develop Oct 8, 2023
11 checks passed
@ankitnayan ankitnayan deleted the feat/dashboard-update branch October 8, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitnayan ankitnayan ankitnayan approved these changes

@YounixM YounixM YounixM left review comments

@makeavish makeavish makeavish left review comments

@CKanishka CKanishka CKanishka left review comments

@Rajat-Dabade Rajat-Dabade Awaiting requested review from Rajat-Dabade

@srikanthccv srikanthccv Awaiting requested review from srikanthccv srikanthccv is a code owner

Assignees

@palashgdev palashgdev

Labels
enhancement New feature or request frontend team-fe-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@palashgdev @makeavish @YounixM @ankitnayan @srikanthccv @Rajat-Dabade @CKanishka