-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Save view PRD design changes. #3480
Merged
palashgdev
merged 18 commits into
SigNoz:develop
from
Rajat-Dabade:enhancement-save-view-prd
Sep 12, 2023
Merged
Save view PRD design changes. #3480
palashgdev
merged 18 commits into
SigNoz:develop
from
Rajat-Dabade:enhancement-save-view-prd
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…z into enhancement-save-view
|
srikanthccv
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the functional changes
palashgdev
approved these changes
Sep 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
manishm
pushed a commit
to manishm/SIGFOR
that referenced
this pull request
Sep 27, 2023
* refactor: search in dropdown * refactor: name of the view to i18 * refactor: make the use of useForm from antd * refactor: moved QuerySearchParamNames into save view module * refactor: reset to query build when click on explorer link * refactor: save view prd design changes * refactor: reverted resetQuery in querybuilder * refactor: queryParams to query.ts in querybuilder constants * fix: redirect with saved view is updated * refactor: removed useffect logic for updating query --------- Co-authored-by: Palash Gupta <palashgdev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loom: https://www.loom.com/share/8a54aa1937424ec28596aaf0437bd232?sid=6404acc7-506d-421d-9af1-cf5e620daa10
stacked up on: #3471 (This PR should be merged after #3471 PR )