Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update .github/CODEOWNERS #3539

Merged
merged 4 commits into from
Dec 13, 2023
Merged

chore: update .github/CODEOWNERS #3539

merged 4 commits into from
Dec 13, 2023

Conversation

srikanthccv
Copy link
Member

No description provided.

@request-info
Copy link

request-info bot commented Sep 13, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the chore label Sep 13, 2023
@ankitnayan
Copy link
Collaborator

Maybe we should introduce folder wise owners in backend otherwise all 5-6 folks will be added as reviewer in every backend PR

prashant-shahi
prashant-shahi previously approved these changes Sep 13, 2023
@prashant-shahi
Copy link
Member

@ankitnayan Shouldn't the backend related PRs be relevant for backend team to take a look at?

Perhaps not for Makefile and .git*, however query-service and go.* should be okay backend team to look at.
And approve from their end to unblock the person.

@srikanthccv
Copy link
Member Author

The folder approach is brittle. While some folders have specific logic, overall files are distributed over several folders containing various changes. And with the folder-wise assignment, when the owners make changes (usually the case), no one is assigned.

@srikanthccv
Copy link
Member Author

Or I can remove the CODEOWNERS for query-serivce and let the PR authors select who they want to get reviews from. Let me know what you think.

@ankitnayan
Copy link
Collaborator

let the PR authors select who they want to get reviews from

this looks good to me

@srikanthccv
Copy link
Member Author

Updated

@srikanthccv
Copy link
Member Author

@ankitnayan merge this. Let the author of PR select the reviewers for a change.

@ankitnayan ankitnayan merged commit c7b59d4 into develop Dec 13, 2023
11 checks passed
@ankitnayan ankitnayan deleted the update-codeowners branch December 13, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants