-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update .github/CODEOWNERS #3539
Conversation
We would appreciate it if you could provide us with more info about this issue/pr! |
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
Maybe we should introduce folder wise owners in backend otherwise all 5-6 folks will be added as reviewer in every backend PR |
@ankitnayan Shouldn't the backend related PRs be relevant for backend team to take a look at? Perhaps not for |
The folder approach is brittle. While some folders have specific logic, overall files are distributed over several folders containing various changes. And with the folder-wise assignment, when the owners make changes (usually the case), no one is assigned. |
Or I can remove the CODEOWNERS for query-serivce and let the PR authors select who they want to get reviews from. Let me know what you think. |
this looks good to me |
Updated |
@ankitnayan merge this. Let the author of PR select the reviewers for a change. |
No description provided.