feat: added services page playwright tests #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We would appreciate it if you could provide us with more info about this issue/pr! |
vikrantgupta25
force-pushed
the
services-test
branch
from
775715f
to
3ff7156
Compare
vikrantgupta25
force-pushed
the
services-test
branch
from
cc79351
to
c8edc18
Compare
|
this is base setup this test would be extended to cover happy / edge case flows |
YounixM
approved these changes
Nov 9, 2023
|
Congrats on merging your first pull request! |
palashgdev
reviewed
Nov 9, 2023
| await expect(p99Latency).toEqual('P99 latency (in ms)'); | ||
| const errorRate = await page | ||
| .locator( | ||
| `th[aria-label*="this column's title is Error Rate (% of total)"] .ant-table-column-title`, |
There was a problem hiding this comment.
would recommend to add data test id / constant hard code thing would not scale
There was a problem hiding this comment.
yes will add data-test-id's when completing the flow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Case added :-
No Services Test ->
With Services Data ->