[Feat]: Threshold in dashboard for Value Component #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
November 8, 2023 18:04
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
for this one 
can use the same instance |
|
we can take this one later: while dropping highlight the area |
|
user can't type in few dropdown in threshold area |
|
edit and view mode border is not looking same 
|
|
should update the state in debounce manner Screen.Recording.2023-11-13.at.6.27.01.PM.mov |
added 9 commits
November 15, 2023 10:10
palashgdev
previously approved these changes
Nov 15, 2023
YounixM
reviewed
Nov 15, 2023
YounixM
reviewed
Nov 15, 2023
YounixM
reviewed
Nov 15, 2023
frontend/src/container/NewWidget/RightContainer/Threshold/ColorSelector.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Nov 15, 2023
frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Nov 15, 2023
frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Nov 15, 2023
frontend/src/container/NewWidget/RightContainer/Threshold/Threshold.tsx
Outdated
Show resolved
Hide resolved
YounixM
reviewed
Nov 15, 2023
YounixM
previously approved these changes
Nov 15, 2023
Rajat-Dabade
dismissed stale reviews from YounixM and palashgdev
via
7443afa
palashgdev
approved these changes
Nov 15, 2023
|
Closes #1600 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRD link: https://www.notion.so/signoz/PRD-Visualise-thresholds-in-dashboard-widgets-cde78a4773a14540a78de693086fd813?pvs=4
Close: #3913
https://www.loom.com/share/1ab5fa9d31f5419e9b965a2fe6220df3?sid=db495977-f2d9-4522-bd57-c36ea8fa8581