chore: fix dropped errors in tests

[alrs]

This picks up two dropped err variables in tests.

Summary by CodeRabbit

• Bug Fixes
  • Improved error handling in the cold storage feature to ensure reliability during data retrieval and storage operations.

[srikanthccv]

Is there anywhere else the error is ignored? I would like to see them fixed in one commit.

[coderabbitai]

Walkthrough

The recent update focuses on enhancing error handling within the cold_storage_test.go file, specifically targeting the setTTL and getTTL functions. These improvements ensure that errors during HTTP request creation are properly checked and managed, bolstering the reliability of the testing process.

Changes

File	Change Summary
.../tests/cold_storage_test.go	Improved error handling for HTTP request creation in setTTL and getTTL.

🏈🐰 In the land of code and bits, where tests and functions intermix,
A rabbit hopped with joyful tricks, celebrating the code that clicks.
As Chiefs and 49ers clash in a spirited bowl,
Our code too, plays its role, striving for a flawless goal.
In this game of wit and might, let's cheer for both sides,
For in the end, it's joy and pride, that our spirited rivalry provides. 🎉🏆

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3ce385e and 2e7045b.

Files selected for processing (1)

• pkg/query-service/tests/cold_storage_test.go (2 hunks)

Additional comments: 3

pkg/query-service/tests/cold_storage_test.go (3)

• 31-33: Ensure that the error handling added for HTTP request creation in setTTL is consistent with the project's error handling strategy. This change correctly addresses the issue of previously ignored errors.
• 135-135: The use of require.NoError for error handling in getTTL is appropriate for test cases, ensuring that any error during HTTP request creation is immediately flagged and the test fails accordingly.
• 28-36: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-205]

No further error handling issues detected in the rest of the file. The changes made are consistent with the PR's objectives to improve error handling in the cold_storage_test.go file.