Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Nan filtering is added #4000

Merged
merged 6 commits into from
Nov 21, 2023
Merged

feat: Nan filtering is added #4000

merged 6 commits into from
Nov 21, 2023

Conversation

palashgdev
Copy link
Contributor

Screenshot 2023-11-20 at 5 11 05 PM

Close #3999

@palashgdev palashgdev self-assigned this Nov 20, 2023
@github-actions github-actions bot added the enhancement New feature or request label Nov 20, 2023
@YounixM
Copy link
Collaborator

YounixM commented Nov 21, 2023

Approving for now

We should be handling this in all charts

Raise a ticket on BE to handle the below requirement

Data for Uplot

  1. Computed Uplot Data
  2. Handle sorting
  3. Handle NaN

@palashgdev palashgdev merged commit 7e87df2 into develop Nov 21, 2023
11 checks passed
@palashgdev palashgdev deleted the fix/appdex branch November 21, 2023 09:57
@palashgdev palashgdev mentioned this pull request Nov 21, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

Assignees

@palashgdev palashgdev

Labels
enhancement New feature or request frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FE: Add Support of NaN in uplot in apm charts
3 participants
@palashgdev @YounixM @makeavish