fix: tab in license page aligned properly #4006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi SigNoz team,
Fixing #3892
The misalignment of the inkbar under the tabs in license page was due to the asynchronous nature of the 't' function used for translation. Since the label for the tabs were using the 't' function there was a delay which led to incorrect calculations for the ink bar's size and position.
To fix this, I've used 'ready' property from the useTranslation hook to ensure all the translations for the specified namespace is fully loaded before the final Tabs component is rendered.
Here are the images of properly aligned inkbar.