Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dashboard perf improvements #4010

Merged
merged 6 commits into from
Nov 30, 2023
Merged

feat: dashboard perf improvements #4010

merged 6 commits into from
Nov 30, 2023

Conversation

YounixM
Copy link
Collaborator

@YounixM YounixM commented Nov 21, 2023 •
edited
Loading

@request-info Request Info
Copy link

request-info bot commented Nov 21, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

@github-actions github-actions bot added the enhancement New feature or request label Nov 21, 2023
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@srikanthccv srikanthccv self-assigned this Nov 21, 2023
@srikanthccv srikanthccv self-requested a review November 21, 2023 12:39
@YounixM YounixM force-pushed the dashboard-perf-improvements branch 3 times, most recently from 4a4e8f5 to 7fc60e0 Compare November 23, 2023 09:11
@srikanthccv
Copy link
Member

@YounixM please resolve the conflicts and let's get this merged

@palashgdev
Copy link
Contributor

palashgdev commented Nov 27, 2023 •
edited
Loading

can you please list down the changes which are fixed

also attach before and after screenshot

@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

1 similar comment
@github-actions GitHub Actions
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@YounixM
Copy link
Collaborator Author

YounixM commented Nov 28, 2023

@palashgdev @Rajat-Dabade: Please review and approve. We can merge this.

We need to add more unit test cases for variableItem component. Will take it up in our automation effort.

srikanthccv
srikanthccv approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the variable update part. LGTM.

@srikanthccv
Copy link
Member

@Rajat-Dabade @palashgdev Please review the changes.

@YounixM
Copy link
Collaborator Author

YounixM commented Nov 30, 2023

@Rajat-Dabade : Will take up test related comments in next PR.

Rajat-Dabade
Rajat-Dabade approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@YounixM
Copy link
Collaborator Author

YounixM commented Nov 30, 2023

Have marked all conversations as resolved to complete checks. Will take them up in next PR.

@YounixM YounixM merged commit b2d6d75 into develop Nov 30, 2023
11 checks passed
@srikanthccv srikanthccv deleted the dashboard-perf-improvements branch November 30, 2023 09:07
@srikanthccv srikanthccv mentioned this pull request Jan 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srikanthccv srikanthccv srikanthccv approved these changes

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@palashgdev palashgdev Awaiting requested review from palashgdev

Assignees

@srikanthccv srikanthccv

Labels
enhancement New feature or request request-more-info
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YounixM @srikanthccv @palashgdev @Rajat-Dabade