Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dashboard delete is fixed and toast message is added #4050

Merged
merged 3 commits into from
Nov 24, 2023
Merged

fix: dashboard delete is fixed and toast message is added #4050

merged 3 commits into from
Nov 24, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Nov 23, 2023 •
edited
Loading

Close SIG-457
Close #4041

@palashgdev palashgdev self-assigned this Nov 23, 2023
@github-actions github-actions bot added the bug Something isn't working label Nov 23, 2023
@SigNoz SigNoz deleted a comment from github-actions bot Nov 23, 2023
Rajat-Dabade
Rajat-Dabade approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@palashgdev palashgdev merged commit fc4cdea into develop Nov 24, 2023
11 checks passed
@palashgdev palashgdev deleted the palash/sig-457 branch November 24, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YounixM YounixM YounixM approved these changes

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

Assignees

@palashgdev palashgdev

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in deleting dashboard
3 participants
@palashgdev @YounixM @Rajat-Dabade