Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(FE): render tooltip if full name of attributes/tag in query builder over hover #4071

Merged
merged 2 commits into from
Dec 8, 2023
Merged

fix(FE): render tooltip if full name of attributes/tag in query builder over hover #4071

merged 2 commits into from
Dec 8, 2023

Conversation

grvv
Copy link
Contributor

@grvv grvv commented Nov 26, 2023

closes #2967

  • Removes native browser title ( because it was slow and difficult to style )
  • Showing users a tooltip only when the attribute name is a really long text.
Screenshot 2023-11-27 at 2 44 03 AM

@welcome Welcome
Copy link

welcome bot commented Nov 26, 2023

Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗

@CLAassistant
Copy link

CLAassistant commented Nov 26, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

@grvv grvv mentioned this pull request Nov 26, 2023
Closed
@palashgdev
Copy link
Contributor

@YounixM please have a look and merge above PR

Rajat-Dabade
Rajat-Dabade approved these changes Dec 8, 2023
View reviewed changes
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@palashgdev palashgdev merged commit 6dd34a7 into SigNoz:develop Dec 8, 2023
11 checks passed
@welcome Welcome
Copy link

welcome bot commented Dec 8, 2023

Congrats on merging your first pull request!
minion-party
We here at SigNoz are proud of you! 🥳

@srikanthccv
Copy link
Member

@palashgdev please change the title to what the PR does before you merge PRs like this. Nobody knows what a Fix/2967 means. This goes into release notes.

@palashgdev palashgdev changed the title Fix/2967 fix: render tooltip if full name of attributes/tag in query builder over hover Dec 8, 2023
@palashgdev
Copy link
Contributor

@palashgdev please change the title to what the PR does before you merge PRs like this. Nobody knows what a Fix/2967 means. This goes into release notes.

make sense updated 👍

@palashgdev palashgdev changed the title fix: render tooltip if full name of attributes/tag in query builder over hover fix(FE): render tooltip if full name of attributes/tag in query builder over hover Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rajat-Dabade Rajat-Dabade Rajat-Dabade approved these changes

@palashgdev palashgdev palashgdev approved these changes

@YounixM YounixM Awaiting requested review from YounixM YounixM is a code owner

Assignees

@grvv grvv

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to see full name of attributes/tag in query builder
5 participants
@grvv @CLAassistant @palashgdev @srikanthccv @Rajat-Dabade