[Fix]: threshold in alerts #4074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YounixM
reviewed
Nov 27, 2023
|
These are the main issues I could find
No threshold line even though there is threshold 
|
Rajat-Dabade
force-pushed
the
gh-4032
branch
from
27916b9
to
8baf458
Compare
srikanthccv
previously approved these changes
Nov 30, 2023
|
Tested
|
added 11 commits
December 1, 2023 12:32
srikanthccv
approved these changes
Dec 1, 2023
YounixM
reviewed
Dec 1, 2023
| @@ -110,6 +105,9 @@ function ChartPreview({ | |||
|
|
|||
| const isDarkMode = useIsDarkMode(); | |||
|
|
|||
| const optionName = | |||
| getFormatNameByOptionId(alertDef?.condition.targetUnit || '') || ''; | |||
There was a problem hiding this comment.
Should we be calling the function only if the targetUnit exists?
YounixM
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #4032
Loom: https://www.loom.com/share/3c483f18b6e948df9a7f686336ef2a8a