Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updated the form value on mount #4076

Merged
merged 2 commits into from
Nov 28, 2023
Merged

fix: updated the form value on mount #4076

merged 2 commits into from
Nov 28, 2023

Conversation

palashgdev
Copy link
Contributor

Close #4037

before:

before.mov

after:

after.mov

@palashgdev palashgdev self-assigned this Nov 27, 2023
@github-actions github-actions bot added the bug Something isn't working label Nov 27, 2023
srikanthccv
srikanthccv previously approved these changes Nov 27, 2023
@Rajat-Dabade
Copy link
Contributor

@palashgdev, In the video demonstration, an observation wherein, upon clicking the "save" button, the displayed value momentarily reverts to its previous state. Similarly, when the "edit" button is clicked, there is a brief period during which the value appears as it was before. The cause of this behaviour is uncertain, I suspect it is because of the useEffect not very sure.

@palashgdev
Copy link
Contributor Author

@palashgdev, In the video demonstration, an observation wherein, upon clicking the "save" button, the displayed value momentarily reverts to its previous state. Similarly, when the "edit" button is clicked, there is a brief period during which the value appears as it was before. The cause of this behaviour is uncertain, I suspect it is because of the useEffect not very sure.

thanks component is mounted though isLoading is replaced with isFetching which fixed the issue

Copy link
Contributor

@Rajat-Dabade Rajat-Dabade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@palashgdev palashgdev merged commit 16839eb into develop Nov 28, 2023
11 checks passed
@palashgdev palashgdev deleted the fix/4037 branch November 28, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert edit data doesn't reflect unless page refreshed
4 participants