Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [GH-4075]: block action on the view section if the dashboard is locked #4089

Merged
merged 6 commits into from
Nov 28, 2023

Conversation

vikrantgupta25
Copy link
Collaborator

@vikrantgupta25 vikrantgupta25 commented Nov 27, 2023

LOCKED :-

Screenshot 2023-11-28 at 6 38 54 PM

UNLOCKED :-

image

TOO MANY LEGENDS VIEW :-

Screen.Recording.2023-11-28.at.10.58.36.PM.mov

Copy link

request-info bot commented Nov 27, 2023

We would appreciate it if you could provide us with more info about this issue/pr!

palashgdev
palashgdev previously approved these changes Nov 28, 2023
@YounixM
Copy link
Collaborator

YounixM commented Nov 28, 2023

@Vikrant2520: We should not show Save and Cancel buttons in case of locked dashboards.

@YounixM YounixM self-requested a review November 28, 2023 15:32
@YounixM YounixM merged commit 01df530 into SigNoz:develop Nov 28, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants