Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added frontend for newly addded flows #4151

Merged
merged 7 commits into from
Dec 20, 2023
Merged

Conversation

Calm-Rock
Copy link
Member

@Calm-Rock Calm-Rock commented Dec 4, 2023

Summary

This PR will include new flows added to the APM and Logs section of the Onboarding docs + updates in the existing docs.

The following new flows are added:
APM

  • .NET

Logs

  • Heroku
  • Vercel
  • Cloudwatch
  • Http

These minor updates have been made:

  • Golang instructions updated according to this PR

@Calm-Rock Calm-Rock marked this pull request as draft December 4, 2023 20:15
Copy link

github-actions bot commented Dec 4, 2023

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Dec 4, 2023
@Calm-Rock Calm-Rock marked this pull request as ready for review December 11, 2023 03:32
@@ -208,12 +234,16 @@ export const hasFrameworks = ({
const { id: moduleID } = module;
const { name: dataSourceName } = dataSource;

console.log(moduleID);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove console log

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

YounixM
YounixM previously approved these changes Dec 18, 2023
Copy link
Collaborator

@YounixM YounixM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed code-wise. LGTM ✅

@YounixM YounixM merged commit 1be4731 into develop Dec 20, 2023
11 checks passed
@makeavish makeavish deleted the onboarding-add-new-flows branch December 20, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants