fix(FE): Fixes the background color of the dashboards full screen view as per the mode selected i.e dark or light mode #4175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome to the SigNoz community! Thank you for your first pull request and making this project better. 🤗 |
|
|
palashgdev
reviewed
Dec 6, 2023
palashgdev
approved these changes
Dec 8, 2023
|
Congrats on merging your first pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the background color of the dashboard's full screen view as per the mode selected by the user , if dark mode then the backgroud color is black else its
#f5f5f5matching the color of the dashboard's other screens.Related Issues / PR's
Issue Link: #4138
Screenshots
Before: - Even if the mode is light the bg was black.
After
