feat: pass abort signal to cancel api request on query-key change or … #4193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YounixM
force-pushed
the
dashboard-query-range-abort-signal
branch
from
509f112
to
1df8fae
Compare
YounixM
force-pushed
the
dashboard-query-range-abort-signal
branch
from
1056a9b
to
d2dadae
Compare
palashgdev
reviewed
Dec 10, 2023
YounixM
force-pushed
the
dashboard-query-range-abort-signal
branch
from
075a074
to
0831e34
Compare
nityanandagohain
previously approved these changes
Dec 12, 2023
YounixM
force-pushed
the
dashboard-query-range-abort-signal
branch
from
0831e34
to
c477d03
Compare
YounixM
force-pushed
the
dashboard-query-range-abort-signal
branch
from
7be73a7
to
066e8bf
Compare
palashgdev
reviewed
Dec 12, 2023
palashgdev
previously approved these changes
Dec 12, 2023
frontend/src/container/PipelinePage/PipelineListsView/Preview/hooks/usePipelinePreview.ts
Show resolved
Hide resolved
palashgdev
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dashboard unmount
Summary
Pass abort signal to cancel API request on query-key change or dashboard unmount
Related Issues / PR's
Fixes #4147
Before:
https://www.loom.com/share/a10502d695be4fd5ab40140ca136d015?sid=0509f83f-33ab-40a0-9cba-288af24b5193
After:
https://www.loom.com/share/1914371759ea4f24807813d83eee0367?sid=6d5a1658-8e27-4fcc-9043-4cb65d38c9c3)
Affected Areas and Manually Tested Areas
Dashboard Page