Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix]: the min data point as 0 in time series #4203

Merged
merged 4 commits into from
Dec 15, 2023
Merged

[Fix]: the min data point as 0 in time series #4203

merged 4 commits into from
Dec 15, 2023

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented Dec 11, 2023

Before:

Screenshot 2023-12-11 at 2 43 57 PM

Before with threshold:
Screenshot 2023-12-11 at 2 44 18 PM

After:

Screenshot 2023-12-11 at 2 44 50 PM

After with threshold:
Screenshot 2023-12-11 at 2 45 49 PM

Fixes: #4202

Docs: https://www.notion.so/signoz/Logic-for-range-in-uplot-95dbc85dd53d43769fdc0e126b717b32?pvs=4

@github-actions github-actions bot added the bug Something isn't working label Dec 11, 2023
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev
Copy link
Contributor

@Rajat-Dabade it will be good if we can control this one with dashboard json in future?

@srikanthccv
Copy link
Member

Yes, that would be a good addition. What we are fixing in this is the desired behaviour for some users https://signoz-team.slack.com/archives/C05AXQL92BT/p1694622771188419. If it's easier to make this configurable let's do it. If it is non-trivial let address it in separate PR.

@Rajat-Dabade
Copy link
Contributor Author

@srikanthccv I believe storing the minimum and maximum range in the dashboard JSON is not advisable since the values of series data can change dynamically (unless we are computing the min and max from the backend). On the based series data and threshold data which are more likely to change every time, we have to compute the min and max for the chart every time.

Instead, the softmin and softmax, which will be introduced shortly, should be stored in the dashboard JSON where the user can specify the min and max value they want to chart to be.

cc: @palashgdev

@palashgdev
Copy link
Contributor

@srikanthccv I believe storing the minimum and maximum range in the dashboard JSON is not advisable since the values of series data can change dynamically (unless we are computing the min and max from the backend). On the based series data and threshold data which are more likely to change every time, we have to compute the min and max for the chart every time.

Instead, the softmin and softmax, which will be introduced shortly, should be stored in the dashboard JSON where the user can specify the min and max value they want to chart to be.

cc: @palashgdev

I am not recommending storing min, and max in the dashboard JSON all we need to store is whether we want to go ahead with min zero or not it's more kind of a flag

@srikanthccv
Copy link
Member

Please add your points related to min and max here instead #3561. Let's not hold this PR for additional changes.

@srikanthccv srikanthccv merged commit cb1a823 into develop Dec 15, 2023
11 checks passed
@srikanthccv srikanthccv deleted the gh-4202 branch December 15, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Issue]: Time series chart starting from 0
4 participants