-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix]: the min data point as 0 in time series #4203
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
@Rajat-Dabade it will be good if we can control this one with dashboard json in future? |
Yes, that would be a good addition. What we are fixing in this is the desired behaviour for some users https://signoz-team.slack.com/archives/C05AXQL92BT/p1694622771188419. If it's easier to make this configurable let's do it. If it is non-trivial let address it in separate PR. |
@srikanthccv I believe storing the minimum and maximum range in the dashboard JSON is not advisable since the values of series data can change dynamically (unless we are computing the min and max from the backend). On the based series data and threshold data which are more likely to change every time, we have to compute the min and max for the chart every time. Instead, the softmin and softmax, which will be introduced shortly, should be stored in the dashboard JSON where the user can specify the min and max value they want to chart to be. cc: @palashgdev |
I am not recommending storing min, and max in the dashboard JSON all we need to store is whether we want to go ahead with min zero or not it's more kind of a flag |
Please add your points related to min and max here instead #3561. Let's not hold this PR for additional changes. |
Before:
Before with threshold:
![Screenshot 2023-12-11 at 2 44 18 PM](https://private-user-images.githubusercontent.com/26198062/289484148-05d04660-71dd-4028-92bd-4226a94b3229.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NzI1OTYsIm5iZiI6MTcxOTY3MjI5NiwicGF0aCI6Ii8yNjE5ODA2Mi8yODk0ODQxNDgtMDVkMDQ2NjAtNzFkZC00MDI4LTkyYmQtNDIyNmE5NGIzMjI5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDE0NDQ1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTdhOWMwODQwZTE1NWY5OTk2NGUyYTMwYTBiYTVmNDJlYzAxMDY2ZDBiNWJhODcxOTVlZTlkM2FjYzIxNmZhMjMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.4NKsPrafFA0mYXjcwLGL-1lnSHcdrhbfqUTpQz7RzHc)
After:
After with threshold:
![Screenshot 2023-12-11 at 2 45 49 PM](https://private-user-images.githubusercontent.com/26198062/289484569-2f791683-0b5c-48f1-bef5-e4f01130027e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NzI1OTYsIm5iZiI6MTcxOTY3MjI5NiwicGF0aCI6Ii8yNjE5ODA2Mi8yODk0ODQ1NjktMmY3OTE2ODMtMGI1Yy00OGYxLWJlZjUtZTRmMDExMzAwMjdlLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDE0NDQ1NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUyMmYyYTNiZjg0MjY2MTQyOTc2NGViOWIzODIyYjhlZGQ3NDQ1Njg3MGRjNzdhMmI5NThhZDQ4NzY3YzRmMWUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.xdlS_ARkge-vFTFzZkwLUGNcGGHtKG5FdUFksFLTqa4)
Fixes: #4202
Docs: https://www.notion.so/signoz/Logic-for-range-in-uplot-95dbc85dd53d43769fdc0e126b717b32?pvs=4