Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: on create alerts query range format is called to fill the variables #4204

Merged
merged 4 commits into from
Dec 15, 2023

Conversation

palashgdev
Copy link
Contributor

@palashgdev palashgdev commented Dec 11, 2023

Close https://github.com/SigNoz/engineering-pod/issues/1119

before:

Screen.Recording.2023-12-13.at.8.30.43.PM.mov

after:

Screen.Recording.2023-12-13.at.8.31.49.PM.mov

@palashgdev palashgdev self-assigned this Dec 11, 2023
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions github-actions bot added the enhancement New feature or request label Dec 11, 2023
@palashgdev palashgdev marked this pull request as ready for review December 12, 2023 08:20
@palashgdev palashgdev force-pushed the fix/eng/1119 branch 2 times, most recently from 292909e to 969124c Compare December 12, 2023 10:24
@srikanthccv
Copy link
Member

Copy link
Member

@srikanthccv srikanthccv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • Query builder in edit mode
  • Query builder from dashboard panel expand options
  • PromQL in edit mode
  • PromQl dashboard panel expand options

@YounixM
Copy link
Collaborator

YounixM commented Dec 13, 2023

@palashgdev: Before and After recordings don't correspond to each other

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

2 similar comments
Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

Copy link

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@palashgdev
Copy link
Contributor Author

@palashgdev: Before and After recordings don't correspond to each other

@YounixM updated please check

@srikanthccv
Copy link
Member

@YounixM please review.

@srikanthccv srikanthccv merged commit 9d44ce3 into develop Dec 15, 2023
11 checks passed
@srikanthccv srikanthccv deleted the fix/eng/1119 branch December 15, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants